Skip to content
This repository was archived by the owner on Jul 16, 2025. It is now read-only.

Fix handling files with unicode names or contents #661

Merged
Swatinem merged 2 commits into from
Mar 28, 2025
Merged

Fix handling files with unicode names or contents #661

Swatinem merged 2 commits into from
Mar 28, 2025

Conversation

@Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Mar 17, 2025

This adds the git ls-files which instructs git to output files separated by \0, and otherwise output filenames verbatim without any special encoding.

The second fix is related to enforcing utf-8 encoding when reading in file contents in order to produce "file fixes".

Fixes #489, fixes codecov/codecov-action#1550, fixes codecov/codecov-action#1539

@Swatinem Swatinem self-assigned this Mar 17, 2025
@codecov
Copy link

codecov bot commented Mar 17, 2025 •
edited
Loading

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
3600 5 3595 0
View the top 3 failed test(s) by shortest run time 
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions
Copy link

github-actions bot commented Mar 17, 2025 •
edited
Loading

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@Swatinem Swatinem mentioned this pull request Mar 25, 2025
Merged
@Swatinem
Fix handling files with unicode names or contents
64550f7 
This adds the `git ls-files` which instructs git to output files separated by `\0`, and otherwise output filenames verbatim without any special encoding.

The second fix is related to enforcing `utf-8` encoding when reading in file contents in order to produce "file fixes".
@Swatinem Swatinem force-pushed the swatinem/test-unicode-files branch from 3f90e14 to 64550f7 Compare March 27, 2025 07:51
@Swatinem Swatinem merged commit 1c24461 into main Mar 28, 2025
22 of 23 checks passed
@Swatinem Swatinem deleted the swatinem/test-unicode-files branch March 28, 2025 08:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@thomasrockhu-codecov thomasrockhu-codecov thomasrockhu-codecov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Swatinem Swatinem

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failed work with non-ASCII file names FileNotFoundError for non-ASCII file names action fails to process non-ASCII Go source file on Windows

3 participants

@Swatinem @thomasrockhu-codecov