This repository was archived by the owner on Jul 16, 2025. It is now read-only.
Merged
Conversation
giovanni-guidini
approved these changes
Jul 14, 2023
Contributor
giovanni-guidini
left a comment
There was a problem hiding this comment.
LGTM.
Indeed upload_completion might not be the best... maybe trigger-notifications (because that's ultimately what we want to do). But I suppose if you think "we're letting Codecov know we completed our uploads" is not too bad.
I also think it would be better to have consistency between the api endpoint and the CLI command.
This was referenced Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
creating new command that tells codecov that the user has finished uploading and now wants to get notifications - notifications is part of the api endpoint, not related to this change specifically
side note: I feel that 'upload-completion' is not a very descriptive name to what we're trying to do here. Do you think we can name it in a more descriptive way? Let me know if you have better ones