Skip to content
This repository was archived by the owner on Jul 16, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: codecov/codecov-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.1.0
Choose a base ref
...
head repository: codecov/codecov-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.1.1_test
Choose a head ref
  • 15 commits
  • 11 files changed
  • 4 contributors

Commits on Jan 30, 2023

  1. implement code build

    dana-yaish committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    cb57501 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2023

  1. Configuration menu
    Copy the full SHA
    c54b171 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    07576ea View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Merge pull request #79 from codecov/dana/code-build

    implement code build
    dana-yaish authored Mar 6, 2023
    Configuration menu
    Copy the full SHA
    63fe2ad View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Configuration menu
    Copy the full SHA
    80d22d9 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #101 from codecov/dana/aws-detect-ci

    add detect function to CodeBuild ci provider
    dana-yaish authored Mar 8, 2023
    Configuration menu
    Copy the full SHA
    946419b View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Fix path_fixes in upload payload (#103)

    Recently testing the CLI with the new upload endpoint I had the following error (when trying to upload the CLI itself)
    ```
    TypeError: keys must be str, int, float, bool or None, not PosixPath
    Error: Process completed with exit code 1.
    ```
    
    After some digging I found the keys in question
    ```
    Finding the PosixPath
    Key languages/languages.c is PosixPath. Origin: .path_fixes.value[languages/languages.c]
    Key tests/data/files_to_fix_examples/sample.cpp is PosixPath. Origin: .path_fixes.value[tests/data/files_to_fix_examples/sample.cpp]
    Key tests/data/files_to_fix_examples/sample.go is PosixPath. Origin: .path_fixes.value[tests/data/files_to_fix_examples/sample.go]
    Key tests/data/files_to_fix_examples/sample.kt is PosixPath. Origin: .path_fixes.value[tests/data/files_to_fix_examples/sample.kt]
    Key tests/data/files_to_fix_examples/sample.php is PosixPath. Origin: .path_fixes.value[tests/data/files_to_fix_examples/sample.php]
    Finding the PosixPath ================ END
    ```
    
    They come from the path_fixes, which are of class Path, but need to be strings.
    To solve this we simply cast them to string while building the payload.
    
    The reason this was not picked up in the unit tests before is that we were already passing strings, not Path as it should be.
    giovanni-guidini authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    735de5f View commit details
    Browse the repository at this point in the history
  2. Cast multiple=True args in upload to list (#104)

    Recently when trying out the CLI with the new upload endpoint I tried to use the `--exclude` option but got the following error:
    ```
    File "/Users/giovannimguidini/Projects/GitHub/codecov-cli/codecov_cli/services/upload/coverage_file_finder.py", line 179, in find_coverage_files
        default_folders_to_ignore + self.folders_to_ignore,
    TypeError: can only concatenate list (not "tuple") to list
    ```
    
    Investigating it deeper we try to merge 2 lists, with one of them being actually a tuple indeed:
    ```
    default_folders_to_ignore has type <class 'list'>
    self.folders_to_ignore has type <class 'tuple'>
    ```
    
    Click documentation doesn't specify if the default cliss for options with `multiple=True` is `tuple` or `list`, nor did I find a click type for it. So instead I'm just casting the argument passed by click to be sure. I changed the default so it would still work if we don't use those options.
    giovanni-guidini authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    bc1ee67 View commit details
    Browse the repository at this point in the history
  3. Update CI workflows. (#102)

    We have setup a workflow for releasing codecov-cli. Currently it runs on every push to master. If you look at the releases page there are MANY releases being created as drafts. That polutes the visibility of true releases. Furthermore, the only asset we have being built works only on Linux distros, and we'd like to provide something for macos and windows users as well.
    
    We also have redundant CI jobs for PRs and master on push.
    
    To address all those concerns, first we are updating the CI workflows. `push_flow.yml` will run the lint-build-test steps for every push we have. This also uploades test coverage to codecov. `release_flow.yml` takes care of building new releases. It only runs when a new TAG is pushed, starting with `v` (for versions).
    
    To help us use the new release flow a new command is begin added to Makefile, the `tag.release` command. It should be used as `make tag.release version=v0.1.0`, for example. It takes care of tagging a new release and uploading it to GitHub, hopefully triggering the release_flow as well.
    
    The changes for `release_flow.yml` were inspired by [this tutorial](https://data-dive.com/multi-os-deployment-in-cloud-using-pyinstaller-and-github-actions/)
    giovanni-guidini authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    e1b3aa3 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Configuration menu
    Copy the full SHA
    c1f0e5f View commit details
    Browse the repository at this point in the history
  2. Update release_flow

    * Include purge release step
    * Add changelog for release
    * Fix issue when creating final release file we had. That was probably because we were using `github.ref` which contains the entire name (e.g. `refs/tags/release`) not simply `release`. Changed to `github.ref_name` to be what we expect.
    giovanni-guidini committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    ac6d09c View commit details
    Browse the repository at this point in the history
  3. Update release_flow.yml

    Rename `build-assets` to `buildassets` for consistency and fix syntax error
    giovanni-guidini authored Mar 13, 2023
    Configuration menu
    Copy the full SHA
    c156415 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3b241d7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5f7701d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e6578f0 View commit details
    Browse the repository at this point in the history
Loading