Add "working-directory:" input#110
Merged
thomasrockhu merged 2 commits intocodecov:masterfrom Dec 16, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
=======================================
Coverage 87.50% 87.50%
=======================================
Files 2 2
Lines 16 16
Branches 2 2
=======================================
Hits 14 14
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Contributor
|
@khaeru, if you resolve the conflicts, I'll take a look at merging this in. |
Contributor
Author
|
Rebased. |
thomasrockhu
approved these changes
Dec 16, 2020
This was referenced Mar 10, 2021
This was referenced Mar 17, 2021
Closed
Closed
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an input
working-directory:, the same name as GitHub Actions uses for generic (run:) steps: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstepsrunThe value is passed to the
cwdoption of GitHub's @actions/exec exec() method:https://github.com/actions/toolkit/blob/d9347d4ab99fd507c0b9104b2cf79fb44fcc827d/packages/exec/src/interfaces.ts#L5-L7
This allows the user to specify in which directory codecov.sh should run.
Other information:
ymloptional input doesn't seem to be working #51 (comment) —this PR differs because it is not trying to address the deprecated/removed-yoption tocodecov.sh, but rather allow configuration of the directory in which the program is executed.ymloptional input doesn't seem to be working #51) to "place codecov.yml at the root of the repository" only covers a subset of possible workflows. This is because GitHub's provided Checkout action has apath:option that controls where each repository is checked out. $GITHUB_WORKSPACE (where this action currently always executes) will be a different directory from "the root of the repository" any timepath:is used; this is common when a workflow checks out two or more repositories. This PR removes this restriction.