This repository was archived by the owner on May 15, 2026. It is now read-only.
feat(builder): should be able to set a custom textures path#44
Merged
Conversation
Owner
|
Thanks for the PR! I think you should be using Otherwise this looks good! |
Contributor
Author
|
Thanks! I was too shy to edit the static function 😅 |
codecat
suggested changes
Nov 22, 2022
Owner
|
I didn't realize they were static actually 😅 changing them to not be static is the right call though. 👍 |
codecat
approved these changes
Nov 22, 2022
Owner
|
Thank you! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal
Hi,
I never use tbloader or TrenchBroom before this morning and I barely coded in c++ in the last 12 years.
But this seems like exactly what I needed for my projects. The only con (after 1h of use) was the static
res::textures/folder path. So I made a quick edit to setup a custom textures path.This should also close the following issue #41.
Trenchboom config
Workflow
2022-11-22.14-27-39.mp4