Skip to content

Feature/web socket#43

Merged
SujithThirumalaisamy merged 16 commits intocode100x:mainfrom
atul24112001:feature/web-socket
Sep 11, 2024
Merged

Feature/web socket#43
SujithThirumalaisamy merged 16 commits intocode100x:mainfrom
atul24112001:feature/web-socket

Conversation

@atul24112001
Copy link
Contributor

@atul24112001 atul24112001 commented Aug 30, 2024

#27

@atul24112001
Copy link
Contributor Author

This is web socket implementation.

Q: Why so many file changes ??
Ans: shifted nextJs app form . to ./next-app folder

Note: Main file/folders to focus on

ws/src/
next-app/app/dashboard/page.tsx
next-app/app/creator/[...creatorId]/page.tsx
next-app/app/components/StreamView.tsx

@atul24112001
Copy link
Contributor Author

Hey @hkirat , I know this is not the best please have a look on four files that I have mentioned in previous comment.

@atul24112001
Copy link
Contributor Author

atul24112001 commented Aug 31, 2024

Screen.Recording.2024-08-31.at.10.29.50.PM.mov

Local sample of current logic -> i am running 2 instance of the ws server. @hkirat

@atul24112001
Copy link
Contributor Author

Hey @hkirat, Updated web-socket logic according to new changes.

@SujithThirumalaisamy
Copy link
Contributor

Looks good. But can you please resolve the conflicts

@atul24112001
Copy link
Contributor Author

@SujithThirumalaisamy done

@atul24112001
Copy link
Contributor Author

Hey @SujithThirumalaisamy , I have updated build.yml according to my understanding please check that.

@SujithThirumalaisamy
Copy link
Contributor

Hey @SujithThirumalaisamy , I have updated build.yml according to my understanding please check that.

Thankyou so muck. Great work. Testing it in local

@SujithThirumalaisamy SujithThirumalaisamy merged commit 844715f into code100x:main Sep 11, 2024
@atul24112001 atul24112001 deleted the feature/web-socket branch September 11, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants