Move compile status state management into CommitDialog#47082
Merged
sanchitmalhotra126 merged 5 commits intosanchit/javalab-dialog-reduxfrom Jul 28, 2022
Merged
Conversation
8 tasks
molly-moen
approved these changes
Jul 6, 2022
…factor/file-errors-redux Move file error message into redux
…factor/split-dialog-header Move Javalab Editor header and dialogs into their own components
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another small Javalab editor prefactor to move the
compileStatusvalue intoCommitDialog.compileStatusis only ever meant to be used byCommitDialoganyway and this helps isolateCommitDialogfromJavalabEditorfor when it's pulled out into a separate component (in an upcoming PR). FWIW we don't actually readcompileStatusinCompileDialogyet, but there's a TODO to add it to the footer.This change is branched off of #47053 which in turn is branched off of Ben's existing Javalab refactor work (#46970). Our plan is to keep these un-merged until the full refactor is in place in order to avoid unnecessarily fixing tests that will get rewritten anyway.
Links
Testing story
Tested locally, ensured that the compile status is updated correctly.
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: