-
Notifications
You must be signed in to change notification settings - Fork 0
transferAllowed does not fail #83
Copy link
Copy link
Open
Labels
0 (Non-critical)Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisationCode style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisationbugSomething isn't workingSomething isn't workingresolvedFinding has been patched by sponsor (sponsor pls link to PR containing fix)Finding has been patched by sponsor (sponsor pls link to PR containing fix)sponsor confirmedSponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Description
Metadata
Metadata
Assignees
Labels
0 (Non-critical)Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisationCode style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisationbugSomething isn't workingSomething isn't workingresolvedFinding has been patched by sponsor (sponsor pls link to PR containing fix)Finding has been patched by sponsor (sponsor pls link to PR containing fix)sponsor confirmedSponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Handle
GeekyLumberjack
Vulnerability details
Impact
transferTokens() will not fail when calling transferAllowed() both transfer() and transferFrom() rely on transferTokens(). Both the name of the function transferAllowed() and the comments above the call show there should be some cases that cause these functions to fail in transferAllowed.
Tools Used
Manual review
Recommended Mitigation Steps
Update transfer allowed to include required failures. If there are none, update the comments and the name of the function.