-
Notifications
You must be signed in to change notification settings - Fork 0
The check for max rate 1000 ole should be inclusive #164
Copy link
Copy link
Open
Labels
1 (Low Risk)Assets are not at risk. State handling, function incorrect as to spec, issues with commentsAssets are not at risk. State handling, function incorrect as to spec, issues with commentsbugSomething isn't workingSomething isn't workingsponsor acknowledgedTechnically the issue is correct, but we're not going to resolve it for XYZ reasonsTechnically the issue is correct, but we're not going to resolve it for XYZ reasons
Metadata
Metadata
Assignees
Labels
1 (Low Risk)Assets are not at risk. State handling, function incorrect as to spec, issues with commentsAssets are not at risk. State handling, function incorrect as to spec, issues with commentsbugSomething isn't workingSomething isn't workingsponsor acknowledgedTechnically the issue is correct, but we're not going to resolve it for XYZ reasonsTechnically the issue is correct, but we're not going to resolve it for XYZ reasons
Handle
Dravee
Vulnerability details
As per the comment, I believe this should be inclusive, as a "max" value is the maximum value that can be taken (That's at least the case in any data query/search. Try a MAX on values in Excel or in SQL):
Otherwise here, "max rate ole" would be
1e18 + 999.Also, an inclusive check
<=costs less gas than an exclusive one>which contains an extra non-equality check.