This repository was archived by the owner on Jan 23, 2025. It is now read-only.
ui-components: Spinner component#132
Merged
koorosh merged 1 commit intocockroachdb:masterfrom Nov 9, 2020
koorosh:ui-spinner
Merged
ui-components: Spinner component#132koorosh merged 1 commit intocockroachdb:masterfrom koorosh:ui-spinner
koorosh merged 1 commit intocockroachdb:masterfrom
koorosh:ui-spinner
Conversation
Spinner component is animated loading indicator which can be used in tables or on pages and indicate intermediate state. This component doesn't reuse existing Spinner icon due to technical limitations. Loading icon is rendered with <path> element which is difficult to animate and make it rotate around SVG central point. That's why current component implements its own loading icon based on <circle> element.
nathanstilwell
approved these changes
Nov 4, 2020
Contributor
nathanstilwell
left a comment
There was a problem hiding this comment.
This looks great. Thank you @koorosh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ui-components // Spinner
Spinner component is animated loading indicator which can be
used in tables or on pages and indicate intermediate state.
This component doesn't reuse existing Spinner icon due to
technical limitations. Loading icon is rendered with
<path>element which is difficult to animate and make it rotate around
SVG central point. That's why current component implements its
own loading icon based on
<circle>element.Checklist
For comparison, loading indicator which is used in Admin UI right now:
