Add more types to mapping dictionary#74
Add more types to mapping dictionary#74bdarnell merged 12 commits intocockroachdb:masterfrom ckoehn:feature/add-more-types
Conversation
|
I noticed the alpha version of CockroachDB ( Any kind of feedback is highly appreciated. |
|
Is there an ETA on when this will get merged? |
|
We should probably add tests for all these type mappings... |
|
@ckoehn this is great, thanks for working on this. As you suggest (and the comment above the type map says), it does seem like it would be a good idea to add some tests for these various mappings. Would it make sense to add that to |
The Cockroach database creates a UNIQUE INDEX implicitly whenever the UNIQUE CONSTRAINT construct is used. Currently we are just ignoring all unique indexes, but we might need to return them and add an additional key `duplicates_constraint` if it is detected as mirroring a constraint. Reference: https://www.cockroachlabs.com/docs/stable/unique.html https://github.com/sqlalchemy/sqlalchemy/blob/55f930ef3d4e60bed02a2dad16e331fe42cfd12b/lib/sqlalchemy/dialects/postgresql/base.py#L723
|
I could review this but:
Therefore I would kindly request that you send separate PRs for the changes. |
|
Thanks for feedback. |
bdarnell
left a comment
There was a problem hiding this comment.
All of this looks good to me; I think we do want all these changes (note that a lot of the commits are closely related - even though there are 11 commits, there are fewer logical changes here).
I think this mainly just needs to be updated for the conflict in dialect.py, and maybe add some tests to ensure that we have some coverage of the newly-added data types.
…types * upstream/master: Update sqlalchemy for information_schema changes
This PR adds more types to the mapping dictionary (See cockroach docs). It will probably fix #73, fix #63 and fix #60.
Additional note:
I was unsure how to add the
ARRAY.