Skip to content

Ensure that StringBuilder implements accessors by value#24

Merged
knz merged 1 commit intocockroachdb:masterfrom
knz:20210601-buf-string
Jul 1, 2021
Merged

Ensure that StringBuilder implements accessors by value#24
knz merged 1 commit intocockroachdb:masterfrom
knz:20210601-buf-string

Conversation

@knz
Copy link
Copy Markdown
Contributor

@knz knz commented Jul 1, 2021

found via crdb's test suite:

=== RUN   TestLint/TestRoachVet
lint_test.go:110:
pkg/kv/kvserver/replica_application_state_machine.go:1057:42: github.com/cockroachdb/errors.AssertionFailedf format %s has arg req of wrong type github.com/cockroachdb/redact/builder.StringBuilder
pkg/kv/kvserver/replica_application_state_machine.go:1099:10: github.com/cockroachdb/errors.AssertionFailedf format %s has arg req of wrong type github.com/cockroachdb/redact/builder.StringBuilder
pkg/kv/kvserver/replica_range_lease.go:623:5: github.com/cockroachdb/cockroach/pkg/util/log.Infof format %s has arg msg of wrong type github.com/cockroachdb/redact/builder.StringBuilder
pkg/migration/migrationmanager/manager.go:329:3: github.com/cockroachdb/cockroach/pkg/util/log.Errorf format %s has arg buf of wrong type github.com/cockroachdb/redact/builder.StringBuilder
pkg/migration/migrationmanager/manager.go:330:20: github.com/cockroachdb/errors.AssertionFailedf format %s has arg buf of wrong type github.com/cockroachdb/redact/builder.StringBuilder

This change is Reviewable

@knz knz merged commit 6fc4110 into cockroachdb:master Jul 1, 2021
@knz knz deleted the 20210601-buf-string branch July 1, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant