deletepacer: don't use fifo.Queue#5524
Merged
RaduBerinde merged 1 commit intocockroachdb:masterfrom Nov 3, 2025
Merged
Conversation
Member
|
This change is |
There is a msan failure that goes away if we switch to using a slice here. This isn't due to some bug in `fifo.Queue` but it looks like a possible compiler bug; the problem will continue to be investigated as part of golang/go#76138 We don't really need the specialized `fifo.Queue` here, a slice is just as good; we just make sure to allocate in reasonable chunks. Fixes cockroachdb#5498
4cbb05d to
8d767cc
Compare
annrpom
approved these changes
Nov 3, 2025
Contributor
annrpom
left a comment
There was a problem hiding this comment.
@annrpom reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, all discussions resolved
Member
Author
|
TFTR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a msan failure that goes away if we switch to using a slice
here. This isn't due to some bug in
fifo.Queuebut it looks like apossible compiler bug; the problem will continue to be investigated as
part of golang/go#76138
We don't really need the specialized
fifo.Queuehere, a slice isjust as good; we just make sure to allocate in reasonable chunks.
Fixes #5498