Merged
Conversation
Member
|
This change is |
e30ba0e to
2a28362
Compare
sumeerbhola
approved these changes
Sep 5, 2023
Collaborator
sumeerbhola
left a comment
There was a problem hiding this comment.
Reviewed 27 of 27 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @RaduBerinde)
internal/constants/constants.go line 8 at r1 (raw file):
const ( oneIf64Bit = ^uint(0) >> 63
and zero if not, yes?
This change makes the necessary code and test changes to allow building on 32-bit, and to make all tests pass. We also add a CI target that uses `GOARCH=386`. Fixes cockroachdb#2853
2a28362 to
b09fcac
Compare
RaduBerinde
commented
Sep 5, 2023
Member
Author
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status: 26 of 27 files reviewed, 1 unresolved discussion (waiting on @sumeerbhola)
internal/constants/constants.go line 8 at r1 (raw file):
Previously, sumeerbhola wrote…
and zero if not, yes?
Yes, added a comment.
Member
Author
|
TFTR! |
This was referenced Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the necessary code and test changes to allow building on 32-bit, and to make all tests pass.
We also add a CI target that uses
GOARCH=386.Fixes #2853