db: return error from Close if open snapshots remain#1994
Merged
jbowens merged 1 commit intocockroachdb:masterfrom Oct 5, 2022
Merged
db: return error from Close if open snapshots remain#1994jbowens merged 1 commit intocockroachdb:masterfrom
jbowens merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
nicktrav
approved these changes
Oct 4, 2022
Contributor
nicktrav
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jbowens)
Return an error from DB.Close if the database has open snapshots. This helps ensure clients don't accidentally leak snapshots, which during normal operation prevents dropping any keys older than the snapshot. Fix cockroachdb#1986.
c2caa5a to
e293db7
Compare
Contributor
Author
|
tftrs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return an error from DB.Close if the database has open snapshots. This helps ensure clients don't accidentally leak snapshots, which during normal operation prevents dropping any keys older than the snapshot.
Fix #1986.