Skip to content

db: wait for table cache releasing goroutines to exit#1929

Merged
jbowens merged 1 commit intocockroachdb:masterfrom
jbowens:tblcache-releasing
Aug 26, 2022
Merged

db: wait for table cache releasing goroutines to exit#1929
jbowens merged 1 commit intocockroachdb:masterfrom
jbowens:tblcache-releasing

Conversation

@jbowens
Copy link
Copy Markdown
Contributor

@jbowens jbowens commented Aug 26, 2022

During tableCache.Close, wait for each shard's releasing goroutine to exit.

Fix #1898.

During tableCache.Close, wait for each shard's releasing goroutine to exit.

Fix cockroachdb#1898.
@jbowens jbowens requested review from a team and erikgrinaker August 26, 2022 13:36
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jbowens
Copy link
Copy Markdown
Contributor Author

jbowens commented Aug 26, 2022

tftr!

@jbowens jbowens merged commit b38417b into cockroachdb:master Aug 26, 2022
@jbowens jbowens deleted the tblcache-releasing branch August 26, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

db: database Close table cache goroutine race

3 participants