db: fix nil-pointer in external iterator range key iteration#1761
Merged
jbowens merged 1 commit intocockroachdb:masterfrom Jun 13, 2022
Merged
db: fix nil-pointer in external iterator range key iteration#1761jbowens merged 1 commit intocockroachdb:masterfrom
jbowens merged 1 commit intocockroachdb:masterfrom
Conversation
Fix a bug where the external iterator initialization failed to initialize the base.Compare to sort overlapping range keys by suffix. Fix cockroachdb#1760.
Member
|
This change is |
nicktrav
approved these changes
Jun 13, 2022
Contributor
nicktrav
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jbowens)
jbowens
commented
Jun 13, 2022
Contributor
Author
jbowens
left a comment
There was a problem hiding this comment.
TFTRs!
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug where the external iterator initialization failed to initialize the
base.Compare to sort overlapping range keys by suffix.
Fix #1760.