db: pool range-key iterator structs, remove Clone#1662
Merged
jbowens merged 1 commit intocockroachdb:masterfrom Apr 21, 2022
Merged
db: pool range-key iterator structs, remove Clone#1662jbowens merged 1 commit intocockroachdb:masterfrom
jbowens merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Add a sync.Pool for pooling of the iteratorRangeKeyState struct which holds an iterator's range key iterator stack. Additionally, remove the (keyspan.FragmentIterator).Clone method. This method is no longer necessary now that visibility of range keys is enforced by the keyspan.MergingIter's transform, which hides keys created more recently than the cloned iterator's sequence number.
nicktrav
approved these changes
Apr 20, 2022
Contributor
nicktrav
left a comment
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jbowens)
jbowens
commented
Apr 21, 2022
Contributor
Author
jbowens
left a comment
There was a problem hiding this comment.
TFTR!
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a sync.Pool for pooling of the iteratorRangeKeyState struct which holds an
iterator's range key iterator stack.
Additionally, remove the (keyspan.FragmentIterator).Clone method. This method
is no longer necessary now that visibility of range keys is enforced by the
keyspan.MergingIter's transform, which hides keys created more recently than
the cloned iterator's sequence number.