add Iterator.RefreshBatchSnapshot()#1655
Closed
erikgrinaker wants to merge 2 commits intocockroachdb:masterfrom
Closed
add Iterator.RefreshBatchSnapshot()#1655erikgrinaker wants to merge 2 commits intocockroachdb:masterfrom
erikgrinaker wants to merge 2 commits intocockroachdb:masterfrom
Conversation
Previously the visibility of indexed batch mutations to open Iterators was undocumented within the API. In practice range deletion and range key mutations added after Iterator construction were never visible. Point operations were immediately visible but could induce odd behavior like repeat keys when switching directions (cockroachdb#943). This commit defines and adopts new behavior for iteration over mutated indexed batches. Seeking an iterator now refreshes the iterator's view of the batch, ensuring the effects of all keys are visible. All mutations applied between seeks are hidden from open iterators. This interface allows iterator reuse in CockroachDB, which always seeks the iterator after mutation. It avoids the unusual repeat-key behavior. Fix cockroachdb#943. Fix cockroachdb#1638.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prototype
Iterator.RefreshBatchSnapshot()based on #1640.