internal/keyspan: clean up InterleavingIter#1654
Merged
jbowens merged 1 commit intocockroachdb:masterfrom Apr 18, 2022
Merged
Conversation
Remove superfluous Split parameter. Split was required for implementing masking, but a direct implementation of masking was replaced with generic Hooks. Also, don't interleave a synthetic marker for empty spans. The synthetic marker doesn't serve any purpose if there are no keys defined over the span. This allows us to return a synthetic marker using an arbitrary Key's kind (rather than always using RANGEKEYSET, even if the Span contained no RANGEKEYSET keys).
Member
|
This change is |
itsbilal
approved these changes
Apr 18, 2022
Contributor
itsbilal
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jbowens)
jbowens
commented
Apr 18, 2022
Contributor
Author
jbowens
left a comment
There was a problem hiding this comment.
TFTR!
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove superfluous Split parameter. Split was required for implementing
masking, but a direct implementation of masking was replaced with generic
Hooks.
Also, don't interleave a synthetic marker for empty spans. The synthetic marker
doesn't serve any purpose if there are no keys defined over the span. This
allows us to return a synthetic marker using an arbitrary Key's kind (rather
than always using RANGEKEYSET, even if the Span contained no RANGEKEYSET keys).