sstable: fix properties block location in docs#1413
Merged
nicktrav merged 1 commit intocockroachdb:masterfrom Dec 15, 2021
Merged
sstable: fix properties block location in docs#1413nicktrav merged 1 commit intocockroachdb:masterfrom
nicktrav merged 1 commit intocockroachdb:masterfrom
Conversation
The properties block is written after any range deletion block that may be present in the sstable. Fix the docs. Follow-up from cockroachdb#1400.
Member
|
This change is |
sumeerbhola
approved these changes
Dec 15, 2021
Collaborator
sumeerbhola
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @nicktrav)
Contributor
Author
|
TFTR! |
sumeerbhola
reviewed
Dec 16, 2021
Collaborator
sumeerbhola
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion
sstable/table.go, line 89 at r1 (raw file):
[index block] (for single level index) [meta range key block] (optional) [meta rangedel block] (optional)
and looks like we write the rangedel block before the range-key block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The properties block is written after any range deletion block that may
be present in the sstable.
Fix the docs.
Follow-up from #1400.