Conversation
|
This change is |
cfe3434 to
c33ac73
Compare
rafiss
left a comment
There was a problem hiding this comment.
thanks for the update! small request
Reviewable status: 0 of 16 files reviewed, 1 unresolved discussion (waiting on @irfansharif and @rafiss)
Gopkg.toml, line 79 at r1 (raw file):
[[constraint]] name = "github.com/cockroachdb/cockroach-go" revision = "b7c8285b7ed3b7e117851f11bdb56ad33cc16320"
would you mind specifying it using version = v2.0.3 instead? (i just pushed a new tag to cockroach-go)
c33ac73 to
8dd4206
Compare
Picks up cockroachdb/cockroach-go#81. Cleans up test code along the way to work with latest cockroach-go (testserver.NewTestServer already starts the server it seems, there's no need to start it again).
8dd4206 to
f9b1147
Compare
irfansharif
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 16 files reviewed, 1 unresolved discussion (waiting on @rafiss)
Gopkg.toml, line 79 at r1 (raw file):
Previously, rafiss (Rafi Shamim) wrote…
would you mind specifying it using
version = v2.0.3instead? (i just pushed a new tag tocockroach-go)
Done.
rafiss
left a comment
There was a problem hiding this comment.
lgtm!
Reviewed 14 of 16 files at r1, 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rafiss)
Picks up cockroachdb/cockroach-go#81.