kvserver: remove unused snapshot fields#99884
Conversation
|
This change is |
ab3dc15 to
8f518c1
Compare
90351c8 to
2a5e5c5
Compare
|
This can be merged into 24.1 if #102629 goes into 23.2. That patch stops reading the field everywhere, but this patch actually removes the fields. |
fd58808 to
a25f360
Compare
a25f360 to
e461583
Compare
e461583 to
6bcebd2
Compare
Does this presume that upgrades from 23.2 to 24.1 will happen from a 23.2 minor version that contains this patch? That won't always be true, will it? Upd: Ah, realized the date of that message :) The patch actually made it to .0, so this should be good. |
|
All the 23.2 builds have that patch (it was merged prior to the 23.2 branch) so it will be ok from any 23.2.x version. However we could consider deferring this until 24.2 if we want to support 23.1 -> 24.1 upgrades.
|
714cd36 to
7eb40c9
Compare
kvoli
left a comment
There was a problem hiding this comment.
Reviewed 6 of 7 files at r1, 16 of 16 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @andrewbaptist)
pkg/kv/kvserver/store_snapshot.go line 1394 at r2 (raw file):
} else if header.SenderQueueName == kvserverpb.SnapshotRequest_OTHER { s.metrics.RangeSnapshotRebalancingRcvdBytes.Inc(inc) } else { // replicate queue does both types, so need to split
nit: move the comment below and capitalize.
pkg/kv/kvserver/client_merge_test.go line 3726 at r1 (raw file):
sstNames []string, ) error { // Only verify snapshots of type VIA_SNAPSHOT_QUEUE and on the range under
nit: should the VIA_SNAPSHOT_QUEUE part of this comment be removed?
This commit removes a number of unused fields in snapshot messages. Additionally this removes the `unknown` snapshot metric as that is always 0 today as there is no longer any way for it to be populated. Release note: None Epic: none
7eb40c9 to
aa6d150
Compare
|
bors r=kvoli |
|
Build succeeded: |
This commit removes a number of unused fields in snapshot messages.
Release note: None
Epic: none