roachtest: add back backups to disk-stalled tests#99871
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 30, 2023
Merged
roachtest: add back backups to disk-stalled tests#99871craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Backups were inadvertently disabled in cockroachdb#99747 (to simplify testing). As there is no good reason to run without them, re-enable the backups during the test. Release note: None.
Member
|
This change is |
jbowens
approved these changes
Mar 29, 2023
Contributor
jbowens
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @smg260 and @srosenberg)
Collaborator
Author
|
TFTR! bors r=jbowens |
Collaborator
Author
|
bors retry |
Contributor
|
Already running a review |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backups were inadvertently disabled in #99747 (to simplify testing). As there is no good reason to run without them, re-enable the backups during the test.
Release note: None.
Epic: CRDB-20293