kvserver: add metrics for Entries bytes read#99806
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Apr 14, 2023
Merged
kvserver: add metrics for Entries bytes read#99806craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
pav-kv
approved these changes
Mar 29, 2023
Collaborator
|
Tag #97917? |
c946b5f to
d7f8631
Compare
This tracks the cases where we fall back to reading log entries from storage (i.e. pebble) in `(raft.Storage.Entries)` Ideally this is zero, as everything ought to be served from the raft entry cache. We know that this cache is not configured well[^1] and so we can't really expect this to work, but you can't improve what you don't measure. Additionally, this metric has been useful in investigations related to raft overload[^2]. [^1]: cockroachdb#98666 [^2]: cockroachdb#98576 Epic: none Release note: None
This is counter tracking the bytes returned from the entry cache (via the `Get` and `Scan` methods). Epic: none Release note: None
d7f8631 to
7af4f98
Compare
Member
Author
|
bors r=pavelkalinnikov |
Contributor
|
Build succeeded: |
Member
Author
|
blathers backport 23.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used versions of these for #98576, and they are generally useful.
Part of #97917.
Release note: None
Epic: None