ui: connect metrics provider to metrics timescale object#99712
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 28, 2023
Merged
ui: connect metrics provider to metrics timescale object#99712craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
xinhaoz
approved these changes
Mar 27, 2023
| timeScaleState => timeScaleState.scale, | ||
| ); | ||
|
|
||
| export const selectMetricsTime = createSelector( |
Contributor
There was a problem hiding this comment.
nit: Maybe we can remove the createSelector if it just returns the one field.
Previously, the `MetricsDataProvider` component queried the redux store for the `TimeScale` object which contained details of the currently active time window. This piece of state was assumed to update to account for the "live" moving window that metrics show when pre-set lookback time windows are selected. A recent PR: cockroachdb#98331 removed the feature that polled new data from SQL pages, which also disabled polling on metrics pages due to the re-use of `TimeScale`. This commit modifies the `MetricsDataProvider` to instead read the `metricsTime` field of the `TimeScaleState` object. This object was constructed for use by the `MetricsDataProvider` but was not wired up to the component. Resolves cockroachdb#99524 Epic: None Release note: None
8df26bd to
9880ad0
Compare
Collaborator
Author
|
bors r=xinhaoz |
Contributor
|
Build succeeded: |
This was referenced Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
MetricsDataProvidercomponent queried the redux store for theTimeScaleobject which contained details of the currently active time window. This piece of state was assumed to update to account for the "live" moving window that metrics show when pre-set lookback time windows are selected.A recent PR: #98331 removed the feature that polled new data from SQL pages, which also disabled polling on metrics pages due to the re-use of
TimeScale.This commit modifies the
MetricsDataProviderto instead read themetricsTimefield of theTimeScaleStateobject. This object was constructed for use by theMetricsDataProviderbut was not wired up to the component.Resolves #99524
Epic: None
Release note: None