Skip to content

ui: drop index with space#99690

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
maryliag:space-rec
Mar 30, 2023
Merged

ui: drop index with space#99690
craig[bot] merged 1 commit intocockroachdb:masterfrom
maryliag:space-rec

Conversation

@maryliag
Copy link
Copy Markdown
Contributor

Previously, if the index had a space on its name,
it would fail to drop.
This commit adds quotes so it can be executed.

Fixes #97988

Schema Insights
https://www.loom.com/share/04363b7f83484b5da19c760eb8d0de21

Table Details page
https://www.loom.com/share/1519b897a14440ddb066fb2ab03feb2d

Release note (bug fix): Index recommendation to DROP an index that have a space on its name can now be properly executed.

@maryliag maryliag requested review from a team March 27, 2023 17:07
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown

@THardy98 THardy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use the safesql package here, take a look at Identifier, Join and QualifiedIdentifier. Might need a bit of tinkering because of the @ in the string.

Copy link
Copy Markdown
Contributor Author

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

Copy link
Copy Markdown

@THardy98 THardy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)

Previously, if the index had a space on its name,
it would fail to drop.
This commit adds quotes so it can be executed.

Fixes cockroachdb#97988

Release note (bug fix): Index recommendation to DROP an index
that have a space on its name can now be properly executed.
@maryliag
Copy link
Copy Markdown
Contributor Author

bors r+

@maryliag maryliag added backport-22.2.x backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only labels Mar 30, 2023
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 30, 2023

Build succeeded:

@craig craig bot merged commit 331a672 into cockroachdb:master Mar 30, 2023
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Mar 30, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from e439695 to blathers/backport-release-22.2-99690: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@maryliag maryliag deleted the space-rec branch March 30, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

index recommendation fail to apply with space on name

3 participants