ccl/multiregionccl: skip these tests just once#99484
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 27, 2023
matthewtodd:un-double-skip
Merged
ccl/multiregionccl: skip these tests just once#99484craig[bot] merged 1 commit intocockroachdb:masterfrom matthewtodd:un-double-skip
craig[bot] merged 1 commit intocockroachdb:masterfrom
matthewtodd:un-double-skip
Conversation
Part of #98020. These tests were also skipped with datadriven language out in the testdata files in #99121, so let's remove the ad-hoc skips here. Confirming they're still skipped after this change: ``` …/cockroach (un-double-skip +) ./dev test -v pkg/ccl/multiregionccl/ -f=TestMultiRegionDataDriven/regional_by_table ... === RUN TestMultiRegionDataDriven/regional_by_table datadriven_test.go:129: [#98020] === CONT TestMultiRegionDataDriven datadriven_test.go:428: -- test log scope end -- --- PASS: TestMultiRegionDataDriven (0.00s) --- SKIP: TestMultiRegionDataDriven/regional_by_table (0.00s) ... ``` ``` …/cockroach (un-double-skip +) ./dev test -v pkg/ccl/multiregionccl/ -f=TestMultiRegionDataDriven/secondary_region ... === RUN TestMultiRegionDataDriven/secondary_region datadriven_test.go:129: [#98020] === CONT TestMultiRegionDataDriven datadriven_test.go:428: -- test log scope end -- --- PASS: TestMultiRegionDataDriven (0.00s) --- SKIP: TestMultiRegionDataDriven/secondary_region (0.00s) ... ``` Release note: None
Member
|
This change is |
Author
|
Hey, @rafiss, quick change here as I'm looking into these flakes. Would you mind taking a look? |
Author
|
Thanks, @rafiss! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #98020.
These tests were also skipped with datadriven language out in the testdata files in #99121, so let's remove the ad-hoc skips here.
Confirming they're still skipped after this change:
Release note: None