Skip to content

release-23.1: build: promote release candidate to alpha.8#99481

Merged
celiala merged 1 commit intocockroachdb:release-23.1from
celiala:promote-candidate-to-alpha.8
Mar 24, 2023
Merged

release-23.1: build: promote release candidate to alpha.8#99481
celiala merged 1 commit intocockroachdb:release-23.1from
celiala:promote-candidate-to-alpha.8

Conversation

@celiala
Copy link
Copy Markdown
Collaborator

@celiala celiala commented Mar 24, 2023 •
edited
Loading

This advances version.txt to the next release, as per the release process.

Pulled commit 2 from #99387 into its own backport

Release note: None
Epic: REL-283
Release justification: Infra-only change. Sets version to alpha.8

@celiala
build: promote release candidate to alpha.8
d458254 
Release note: None
Epic: REL-283
@celiala celiala requested a review from a team as a code owner March 24, 2023 14:32
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Mar 24, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Mar 24, 2023

This change is Reviewable

@celiala celiala mentioned this pull request Mar 24, 2023
Merged
@celiala celiala merged commit 85b01ce into cockroachdb:release-23.1 Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlinder jlinder jlinder approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@celiala @cockroach-teamcity @jlinder