multitenant: re-enable TestTenantUpgradeInterlock#99216
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 23, 2023
Merged
multitenant: re-enable TestTenantUpgradeInterlock#99216craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
TestTenantUpgradeInterlock was skipped with cockroachdb#99121 because it was timing out regularly. In response to the timeouts however, cockroachdb#98997 was merged to increase the timeout duration for the test (since its run length is proportional to the number of migrations in the release, which has been increasing). Unfortuntely, our wires got crossed and the skip was introduced before the test had a chance to run with the new timeout. cockroachdb#98987 hasn't shown a failure with the new timeout length, so it may be the case that the longer timeout has resolved the problem. Reenabling the test to see if it has better success under the new timeout length. Fixes: cockroachdb#98987 Epic: None Release note: None
7380564 to
878e236
Compare
knz
approved these changes
Mar 22, 2023
Collaborator
Author
|
TFTR! bors r=knz |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestTenantUpgradeInterlock was skipped with #99121 because it was timing out regularly. In response to the timeouts however, #98997 was merged to increase the timeout duration for the test (since its run length is proportional to the number of migrations in the release, which has been increasing). Unfortuntely, our wires got crossed and the skip was introduced before the test had a chance to run with the new timeout. #98987 hasn't shown a failure with the new timeout length, so it may be the case that the longer timeout has resolved the problem.
Reenabling the test to see if it has better success under the new timeout length.
Fixes: #98987
Epic: None
Release note: None