backupccl: stop logging unsanitized backup stmt in schedule executor#99150
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Mar 22, 2023
Merged
backupccl: stop logging unsanitized backup stmt in schedule executor#99150craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Informs cockroachdb#99145 Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
stevendanna
approved these changes
Mar 22, 2023
Collaborator
stevendanna
left a comment
There was a problem hiding this comment.
👍 Thanks for fixing this up.
If we wanted to go a bit further, we have some code in this file for creating redacted backup statements. We could print a redacted backup statement rather than just the schedule ID if we saw value in having the whole statement.
But, I personally thing that just the ID is fine.
Collaborator
Author
|
bors r=stevendanna |
Contributor
|
Build failed: |
Collaborator
Author
|
bors r=retry |
Contributor
|
Build failed (retrying...): |
Collaborator
Author
|
bors r- |
Contributor
|
Canceled. |
This patch ensures that no unsanitized uris or secret keys get written to the jobs table if the backup fails. Informs cockroachdb#99145 Release note: None
Collaborator
Author
|
bors r=stevendanna |
dt
approved these changes
Mar 22, 2023
Contributor
|
Build succeeded: |
This was referenced Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Informs #99145
Release note: None