server: fix DataDistribution server error when creating a tenant#99142
server: fix DataDistribution server error when creating a tenant#99142craig[bot] merged 1 commit intocockroachdb:masterfrom
DataDistribution server error when creating a tenant#99142Conversation
This is a stop-gap commit that enables the DataDistribution endpoint to handle the parts of the key space belonging to secondary tenants without error. Despite no error, the result returned for secondary tenants is not correct. The DataDistribution endpoint was written before cockroachdb#79700, and therefore doesn't know that multiple tables can exist within a range. Additionally, the results for the system tenant will be incorrect soon because cockroachdb#81008 is in progress. Fixes: cockroachdb#97993 Release note: None
|
This change is |
dhartunian
left a comment
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @zachlite)
pkg/ccl/serverccl/admin_test.go line 85 at r1 (raw file):
sqlDB.Exec(t, `ALTER PARTITION eu OF TABLE comments CONFIGURE ZONE USING gc.ttlseconds = 9002`) if disableDefaultTestTenant {
why is this conditional here if the value is always true?
zachlite
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ccl/serverccl/admin_test.go line 85 at r1 (raw file):
Previously, dhartunian (David Hartunian) wrote…
why is this conditional here if the value is always true?
I wanted to keep this in sync with the value passed to TestServerArgs.DisableDefaultTestTenant.
If we're running the test through a tenant, we don't need to create a new tenant. Overkill?
dhartunian
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ccl/serverccl/admin_test.go line 85 at r1 (raw file):
Previously, zachlite wrote…
I wanted to keep this in sync with the value passed to
TestServerArgs.DisableDefaultTestTenant.
If we're running the test through a tenant, we don't need to create a new tenant. Overkill?
👍
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error setting reviewers, but backport branch blathers/backport-release-23.1-99142 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/100010/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This is a stop-gap commit that enables the DataDistribution endpoint to handle the parts of the key space belonging to secondary tenants without error.
Despite no error, the result returned for secondary tenants is not correct. The DataDistribution endpoint was written before #79700, and therefore doesn't know that multiple tables can exist within a range.
Additionally, the results for the system tenant will be incorrect soon because #81008 is in progress.
Improvements are tracked by #97942
Fixes: #97993
Release note: None