Skip to content

tracing: allow collection of stack history for Structured spans as well#99120

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
adityamaru:drop-check-to-structured
Mar 21, 2023
Merged

tracing: allow collection of stack history for Structured spans as well#99120
craig[bot] merged 1 commit intocockroachdb:masterfrom
adityamaru:drop-check-to-structured

Conversation

@adityamaru
Copy link
Copy Markdown
Contributor

Previously, we mandated that the span must be Verbose to be able to collect and emit a Structured event containing stack history. This change permits Structured spans to also collect stack history.

Release note: None
Epic: none

Previously, we mandated that the span must be Verbose to be able
to collect and emit a Structured event containing stack history.
This change permits Structured spans to also collect stack history.

Release note: None
Epic: none
@adityamaru adityamaru requested review from a team and dt March 21, 2023 14:22
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@adityamaru
Copy link
Copy Markdown
Contributor Author

bors r=dt

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 21, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 21, 2023

Build succeeded:

@craig craig bot merged commit 18e6641 into cockroachdb:master Mar 21, 2023
@adityamaru adityamaru deleted the drop-check-to-structured branch March 23, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants