Skip to content

roachtest: fix c2c roachtests that read job payload#98981

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
adityamaru:fix-null-scan
Mar 22, 2023
Merged

roachtest: fix c2c roachtests that read job payload#98981
craig[bot] merged 1 commit intocockroachdb:masterfrom
adityamaru:fix-null-scan

Conversation

@adityamaru
Copy link
Copy Markdown
Contributor

In #98608 some changes were made to the c2c roachtests that caused them to break. This change fixes the tests by querying the correct virutal table that interacts with both system.jobs and system.job_info.

Fixes: #98973
Fixes: #98969
Fixes: #98962
Informs: #98669

Release note: None

@adityamaru adityamaru requested a review from msbutler March 19, 2023 14:13
@adityamaru adityamaru requested a review from a team as a code owner March 19, 2023 14:13
@adityamaru adityamaru requested review from renatolabs and srosenberg and removed request for a team March 19, 2023 14:13
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adityamaru
Copy link
Copy Markdown
Contributor Author

bors retry

@adityamaru
Copy link
Copy Markdown
Contributor Author

bors r=stevendanna

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 21, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 21, 2023

Build failed:

In cockroachdb#98608 some changes were made to the c2c roachtests
that caused them to break. This change fixes the tests
by querying the correct virutal table.

Fixes: cockroachdb#98973
Fixes: cockroachdb#98969
Fixes: cockroachdb#98962
Informs: cockroachdb#98669

Release note: None
@adityamaru
Copy link
Copy Markdown
Contributor Author

Both failures look like flakes, lets try again

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 22, 2023

Build succeeded:

@craig craig bot merged commit 4be5775 into cockroachdb:master Mar 22, 2023
@adityamaru
Copy link
Copy Markdown
Contributor Author

blathers backport 23.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants