Skip to content

Revert "Revert "backupccl: disallow restore of backups older than the minimum supported binary version""#98959

Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom
adityamaru:unrevert-restore-policy
Mar 20, 2023
Merged

Revert "Revert "backupccl: disallow restore of backups older than the minimum supported binary version""#98959
craig[bot] merged 2 commits intocockroachdb:masterfrom
adityamaru:unrevert-restore-policy

Conversation

@adityamaru
Copy link
Copy Markdown
Contributor

@adityamaru adityamaru commented Mar 18, 2023

This reverts commit c510676.

Some roachtests rely on fixtures generated before 22.2. To restore
such fixtures that are outside our compatibility window we must run
the restore with unsafe_restore_incompatible_version.

Fixes: #98918
Fixes: #98930
Release note: None
Epic: none

… minimum supported binary version""

This reverts commit c510676.

Release note: None

Epic: none
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@adityamaru adityamaru force-pushed the unrevert-restore-policy branch 2 times, most recently from e21331f to 0f2643e Compare March 19, 2023 13:57
@adityamaru adityamaru requested review from dt and msbutler March 19, 2023 13:57
@adityamaru adityamaru marked this pull request as ready for review March 19, 2023 13:58
@adityamaru adityamaru requested review from a team as code owners March 19, 2023 13:58
@adityamaru adityamaru requested review from a team, smg260 and srosenberg and removed request for a team March 19, 2023 13:58
Some roachtests rely on fixtures generated before 22.2. To restore
such fixtures that are outside our compatibility window we must run
the restore with `unsafe_restore_incompatible_version`.

Fixes: cockroachdb#98918

Release note: None
@adityamaru adityamaru force-pushed the unrevert-restore-policy branch from 0f2643e to d9b6fe7 Compare March 19, 2023 14:18
@adityamaru
Copy link
Copy Markdown
Contributor Author

TFTR!

bors r=dt

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 20, 2023

Build succeeded:

@craig craig bot merged commit 5839fe0 into cockroachdb:master Mar 20, 2023
@adityamaru adityamaru deleted the unrevert-restore-policy branch March 20, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

roachtest: copy/bank/rows=100000,nodes=5,txn=true failed roachtest: can't restore backup

3 participants