feat: allow starting docker container via env variable#98899
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 30, 2023
Merged
feat: allow starting docker container via env variable#98899craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
|
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Release note (general change): Allow setting docker command args via the `COCKROACH_ARGS` environment variable.
|
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
rickystewart
approved these changes
Mar 29, 2023
Collaborator
|
Thanks for the contribution! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #87043 by allowing you to specify args via the
COCKROACH_ARGSenv value instead of a command. This is required to be able to use the official cockroach image with GitHub actions via a service. More details in the issue.Note, do to weirdness with merging commands and env values, I decided that setting the
COCKROACH_ARGSwould ignore any command given. This should reduce issues with people trying to use both ways of specifying args and instead force them to pick one.Release note (general change): Allow setting docker command args via the
COCKROACH_ARGSenvironment variable.