backupccl: fix occassional TestRestoreErrorPropagates flake#98878
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 22, 2023
Merged
Conversation
Member
|
This change is |
stevendanna
approved these changes
Mar 21, 2023
Collaborator
stevendanna
left a comment
There was a problem hiding this comment.
LGTM. There is also the new job stats job. Do we need to do anything to prevent that jpb from starting?
12c7da8 to
ac1707b
Compare
Very rarely under stress race another automatic job would race with the restore and increment the error count. This would result in the count being greater than our expected value of 1. This disables all the automatic jobs eliminating the chance of this race. Fixes: cockroachdb#98037 Release note: None
ac1707b to
f8557fc
Compare
Contributor
Author
|
bors r=stevendanna |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very rarely under stress race another automatic job would race with the restore and increment the error count. This would result in the count being greater than our expected value of 1. This disables all the automatic jobs eliminating the chance of this race.
Fixes: #98037
Release note: None