multitenant: unskip multitenant_admin_function_test#98801
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Mar 17, 2023
ecwall:multitenant_unskip_multitenant_admin_function_test
Merged
multitenant: unskip multitenant_admin_function_test#98801craig[bot] merged 2 commits intocockroachdb:masterfrom ecwall:multitenant_unskip_multitenant_admin_function_test
craig[bot] merged 2 commits intocockroachdb:masterfrom
ecwall:multitenant_unskip_multitenant_admin_function_test
Conversation
Member
|
This change is |
knz
approved these changes
Mar 16, 2023
Fixes #95252 Race conditions between the test and kv can cause the test to flake so retry the query. Release note: None
Contributor
Author
|
bors r=knz |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #95201
This test was flaking because it was verifying exact range start keys
which are non-deterministic.
This was fixed as part of #98483 which allows any value for the range start key
and can now be unskipped.
Release note: None