Skip to content

storage,kv: reenable rewrite concurrency and add format error checking#98711

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
sumeerbhola:suffix_bug
Mar 15, 2023
Merged

storage,kv: reenable rewrite concurrency and add format error checking#98711
craig[bot] merged 1 commit intocockroachdb:masterfrom
sumeerbhola:suffix_bug

Conversation

@sumeerbhola
Copy link
Copy Markdown
Collaborator

Epic: none

Fixes: #97076

Release note: None

@sumeerbhola sumeerbhola requested a review from jbowens March 15, 2023 20:19
@sumeerbhola sumeerbhola requested review from a team as code owners March 15, 2023 20:19
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Mar 15, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @sumeerbhola)

@sumeerbhola
Copy link
Copy Markdown
Collaborator Author

TFTR!

@sumeerbhola
Copy link
Copy Markdown
Collaborator Author

bors r=jbowens

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 15, 2023

Build succeeded:

@craig craig bot merged commit 1d2a647 into cockroachdb:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ccl/kvccl/kvtenantccl: TestTenantUpgrade failed

3 participants