logictest: use v22_2 schema in mixed version test#98695
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 15, 2023
Merged
logictest: use v22_2 schema in mixed version test#98695craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
6a9d819 to
16253ce
Compare
ajwerner
approved these changes
Mar 15, 2023
| @@ -1,5 +1,4 @@ | |||
| # LogicTest: default-configs local-mixed-22.2-23.1 | |||
|
|
|||
michae2
approved these changes
Mar 15, 2023
Collaborator
michae2
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jeffswenson)
pkg/sql/logictest/logictestbase/logictestbase.go line 59 at r1 (raw file):
// bootstrapped at. BootstrapVersion clusterversion.Key // DisableUpgrade prevents the cluster from automatically ruinng upgrading
typo: delete "ruinng"
16253ce to
19a01e5
Compare
Collaborator
Author
|
bors r+ |
Contributor
|
Build failed (retrying...): |
Collaborator
Author
|
bors - |
Contributor
|
Did you mean "r-"? |
Collaborator
Author
|
bors r- |
Contributor
|
Canceled. |
19a01e5 to
49d7658
Compare
Previously, the v22.2-v23.1 mixed version test was using the v22.2 version gate with a v23.1 schema. This caused the alter_table test to fail on PR cockroachdb#98446. The lease protocol only works if the version gates and the schema are in sync. As part of this change I simplified the version configuration in the logic tests so that the only version key is the bootstrap version. It doesn't really make sense to specify a binary version different than the build version. The binary will always have the build version's behavior. This change also deletes the local-v1.1-at-v1.0-noupgrade test. The version can't be described by a version key and the tests do not represent a situation that occurs in real world deployments. Part of cockroachdb#94843 Release note: None
49d7658 to
4424f86
Compare
Collaborator
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the v22.2-v23.1 mixed version test was using the v22.2 version gate with a v23.1 schema. This caused the alter_table test to fail on PR #98446. The lease protocol only works if the version gates and the schema are in sync.
As part of this change I simplified the version configuration in the logic tests so that the only version key is the bootstrap version. It doesn't really make sense to specify a binary version different than the build version. The binary will always have the build version's behavior.
This change also deletes the local-v1.1-at-v1.0-noupgrade test. The version can't be described by a version key and the tests do not represent a situation that occurs in real world deployments.
Part of #94843
Release note: None