execinfra: correctly propagate processorID for LocalProcessors#98654
execinfra: correctly propagate processorID for LocalProcessors#98654craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Previously, this was incorrectly hard-coded as zero. The impact of this seems minor (I believe this would only make it so that we could incorrectly attribute `ComponentStats` object of `planNodeToRowSource` to the wrong processor), but I think it still deserves to be backported. Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
michae2
left a comment
There was a problem hiding this comment.
but I think it still deserves to be backported.
SGTM
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)
|
TFTR! bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 9eb8ec3 to blathers/backport-release-22.2-98654: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Previously, this was incorrectly hard-coded as zero. The impact of this seems minor (I believe this would only make it so that we could incorrectly attribute
ComponentStatsobject ofplanNodeToRowSourceto the wrong processor), but I think it still deserves to be backported.Epic: None
Release note: None