upgrades: use v22_2 bootstrap schema with role_members test#98613
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 15, 2023
Merged
Conversation
Previously the role members test used the v23_1 schema with the V23_1RoleMembersTableHasIDColumns version gate. This caused problems for PR cockroachdb#98446 because the lease schema does not match the lease version gates. Now, the test uses the BootstrapVersionKeyOverride to bootstrap with the V22_2 schema. Setting the cluster version walks the cluster through all of the migrations including the role members migration. Part of cockroachdb#98446 Release Note: none
Member
|
This change is |
ajwerner
approved these changes
Mar 14, 2023
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jeffswenson)
Collaborator
Author
|
bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed: |
Collaborator
Author
|
bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the role members test used the v23_1 schema with the V23_1RoleMembersTableHasIDColumns version gate. This caused problems for PR #98446 because the lease schema does not match the lease version gates.
Now, the test uses the BootstrapVersionKeyOverride to bootstrap with the V22_2 schema. Setting the cluster version walks the cluster through all of the migrations including the role members migration.
Part of #98446
Release Note: none