colmem: allow Allocator max batch size to be customized#98544
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 15, 2023
Merged
colmem: allow Allocator max batch size to be customized#98544craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
201855b to
ddc28ec
Compare
yuzefovich
approved these changes
Mar 15, 2023
Member
yuzefovich
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @cucaroach)
pkg/sql/colmem/allocator.go line 166 at r1 (raw file):
} // SetMaxBatchSize use this to get more or less than the coldata.BatchSize() default.
nit: the comment needs an update.
pkg/sql/colmem/allocator.go line 232 at r1 (raw file):
// growCapacity grows the capacity exponentially or up to minDesiredCapacity // (whichever is larger) without exceeding coldata.BatchSize().
nit: s/coldata.BatchSize()/maxBatchSize/g.
Previously this was hardcoded to coldata.BatchSize or 1024, now it can be increased or decreased. Epic: CRDB-18892 Informs: cockroachdb#91831 Release note: None
ddc28ec to
d987fd4
Compare
Contributor
Author
|
bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this was hardcoded to coldata.BatchSize or 1024, now it
can be increased or decreased.
Epic: CRDB-18892
Informs: #91831
Release note: None