sqlliveness: migrate to rbr compatible index#98463
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 14, 2023
Merged
sqlliveness: migrate to rbr compatible index#98463craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
6a61b91 to
21193fb
Compare
2be4e1f to
ac8948c
Compare
This was referenced Mar 13, 2023
be49347 to
aca3d96
Compare
aca3d96 to
076f30e
Compare
ajwerner
approved these changes
Mar 13, 2023
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Reviewed 22 of 22 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained
Migrate sqlliveness to the regional by row compatible index. The version gates are intended to follow the protocol discussed in the comment at the top of upgrades/system_rbr_indexes.go. As part of this change, the legacy session id encoding is treated as belonging to the enum.One region. Treating the legacy encoding as belonging to enum.One simplifies the migration as it is not necessary to wait for old sessions to expire or clear old sessions from the jobs table. Part of cockroachdb#94843 Release note: none
076f30e to
6cd6962
Compare
Collaborator
Author
|
bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate sqlliveness to the regional by row compatible index. The version
gates are intended to follow the protocol discussed in the comment at
the top of upgrades/system_rbr_indexes.go.
As part of this change, the legacy session id encoding is treated as
belonging to the enum.One region. Treating the legacy encoding as
belonging to enum.One simplifies the migration as it is not necessary to
wait for old sessions to expire or clear old sessions from the jobs
table.
Part of #94843
Release note: none