clusterversion: add a gate for new system privileges#98419
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 13, 2023
Merged
clusterversion: add a gate for new system privileges#98419craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
3d26152 to
0428566
Compare
jayshrivastava
approved these changes
Mar 13, 2023
Contributor
jayshrivastava
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding this.
0428566 to
96a8e23
Compare
Collaborator
Author
|
tftr! bors r=jayshrivastava |
Contributor
|
Build failed: |
A 22.2/23.1 mixed version cluster cannot handle new system privileges well. This commit gates their usage and adds a test. Without this gate, the included test would fail and users would not be able to log in to nodes running on the old binary. Release note: None
96a8e23 to
fc50c99
Compare
Collaborator
Author
|
bors r=jayshrivastava |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 22.2/23.1 mixed version cluster cannot handle new system privileges well. This commit gates their usage and adds a test.
Without this gate, the included test would fail and users would not be able to log in to nodes running on the old binary.
Epic: None
Release note: None