cdc: reapply commit with malformed message#98338
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Mar 9, 2023
Merged
cdc: reapply commit with malformed message#98338craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
e244c73 to
ea9706a
Compare
This reverts commit 972b85e from cockroachdb#98135. The above commit has a maflormed commit message. This commit will be reapplied subsequently. Epic: None Release Note: None
ea9706a to
e2a22ae
Compare
samiskin
approved these changes
Mar 9, 2023
Contributor
samiskin
left a comment
There was a problem hiding this comment.
Probably needs the ol' "Resolves #....."
Note: This commit message reapplies the commit 972b85e, which was previously reverted for having an incorrect commit message. Previously, when the schema registry encountered an error when registering a schema, it would retry the request. The problem is that upon hitting an error, we clean the body before retrying. Retrying with an empty body results in a obscure error message. With this change, we now retry with the original request body so the original error is sustained. This change also adds the metric changefeed.schema_registry.retry_count which is a counter for the number of retries performed by the schema registry. Seeing nonzero values indicates that there is an issue with contacting the schema registry and/or registering schemas. Release note (ops change): A new metric changefeed.schema_registry.retry_count is added. This measures the number of request retries performed when sending requests to the schema registry. Observing a nonzero value may indicate improper configuration of the schema registry or changefeed parameters. Epic: None Informs: https://github.com/cockroachlabs/support/issues/2131 Informs: https://github.com/cockroachlabs/support/issues/2129
e2a22ae to
0ee4600
Compare
Contributor
Author
|
bors r=samiskin |
Contributor
|
Build succeeded: |
This was referenced Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cdc: revert commit with malformed message
This reverts commit 972b85e from #98135.
The above commit has a maflormed commit message. This commit will be reapplied subsequently.
Epic: None
Release Note: None
cdc: copy request body when registering schemas
Note: This commit message reapplies the commit 972b85e,
which was previously reverted for having an incorrect commit message.
Previously, when the schema registry encountered an error when
registering a schema, it would retry the request. The problem
is that upon hitting an error, we clean the body before retrying.
Retrying with an empty body results in a obscure error message.
With this change, we now retry with the original request body
so the original error is sustained.
This change also adds the metric changefeed.schema_registry.retry_count
which is a counter for the number of retries performed by the schema
registry. Seeing nonzero values indicates that there is an issue
with contacting the schema registry and/or registering schemas.
Release note (ops change): A new metric changefeed.schema_registry.retry_count
is added. This measures the number of request retries performed when
sending requests to the schema registry. Observing a nonzero value may indicate
improper configuration of the schema registry or changefeed parameters.
Epic: None
Informs: https://github.com/cockroachlabs/support/issues/2131
Informs: https://github.com/cockroachlabs/support/issues/2129