Skip to content

sql: enable TestSQLStatsDataDriven#98337

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
j82w:89861
Mar 15, 2023
Merged

sql: enable TestSQLStatsDataDriven#98337
craig[bot] merged 1 commit intocockroachdb:masterfrom
j82w:89861

Conversation

@j82w
Copy link
Copy Markdown
Contributor

@j82w j82w commented Mar 9, 2023

Adding retry logic to the execute command, and
enabling the test. All previous builds with failures
are no longer available. No failures on testing
locally with stress.

Epic: none
Closes: #89861

Release note: none

@j82w j82w requested a review from a team March 9, 2023 20:27
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @j82w)

@j82w
Copy link
Copy Markdown
Contributor Author

j82w commented Mar 10, 2023

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 10, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 10, 2023

Build failed:

Adding retry logic to the execute command, and
enabling the test. All previous builds with failures
are no longer available. No failures on testing
locally with stress.

Epic: none
Closes: #89861

Release note: none
@j82w
Copy link
Copy Markdown
Contributor Author

j82w commented Mar 14, 2023

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 14, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 14, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 14, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 15, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 15, 2023

Build succeeded:

@craig craig bot merged commit 9b43dc5 into cockroachdb:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestSQLStatsDataDriven is flaky

3 participants