ui: make upgrade error message encompass more tables#98312
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 9, 2023
Merged
ui: make upgrade error message encompass more tables#98312craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Previously, we only show the upgrade error message when querying using the sql api in the cases where the server error message says either a column does not exist or the specific table `crdb_internal.txn_cluster_insights`. This commit expands that to any table. Epic: none Release note (ui change): users will see the upgrade error message when a response from the sql api says that a relation or column does not exist
Member
|
This change is |
maryliag
approved these changes
Mar 9, 2023
Contributor
maryliag
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)
Contributor
Author
|
TFTR! |
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we only show the upgrade error message when querying using the sql api in the cases where the server error message says either a column does not exist or the specific table
crdb_internal.txn_cluster_insights. This commit expands that to any table.Epic: none
Release note (ui change): users will see the upgrade error message when a response from the sql api says that a relation or column does not exist