kvserver: add minimum cpu lb split threshold#98250
kvserver: add minimum cpu lb split threshold#98250craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
Previously, `kv.range_split.load_cpu_threshold` had no minimum setting value. It is undesirable to allow users to set this setting to low as excessive splitting may occur. `kv.range_split.load_cpu_threshold` now has a minimum setting value of `10ms`. Resolves: cockroachdb#98107 Release note (ops change): `kv.range_split.load_cpu_threshold` now has a minimum setting value of `10ms`.
9ee220b to
903747d
Compare
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
andrewbaptist
left a comment
There was a problem hiding this comment.
LGTM
As noted some of these parameters should not be TenantWritable, but you were going to create a separate PR for that.
|
TYFTR
Filed #98347 |
|
bors r=andrewbaptist |
|
Build succeeded: |
Previously,
kv.range_split.load_cpu_thresholdhad no minimum setting value. It is undesirable to allow users to set this setting to low as excessive splitting may occur.kv.range_split.load_cpu_thresholdnow has a minimum setting value of10ms.See #96869 for additional context on the threshold.
Resolves: #98107
Release note (ops change):
kv.range_split.load_cpu_thresholdnow has a minimum setting value of10ms.