insights: add status field to transaction insights#98217
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 13, 2023
Merged
insights: add status field to transaction insights#98217craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Part of: cockroachdb#87785. Previously, execution insights did not keep track of a transaction's status. This commit adds the `status` field to transaction insights. A transaction's status is determined from its statements: if all statement statuses are `Completed`, then the transaction status is `Completed` and if there is one `Failed` statement status, then the transaction status is also `Failed`. Release note (sql change): Added `status` column to `crdb_internal.[cluster|node]_txn_execution_insights` virtual tables.
Member
|
This change is |
This was referenced Mar 8, 2023
maryliag
approved these changes
Mar 10, 2023
Contributor
maryliag
left a comment
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @gtr)
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: #87785.
Previously, execution insights did not keep track of a transaction's
status. This commit adds the
statusfield to transaction insights. Atransaction's status is determined from its statements: if all
statement statuses are
Completed, then the transaction status isCompletedand if there is oneFailedstatement status, then thetransaction status is also
Failed.Release note (sql change): Added
statuscolumn tocrdb_internal.[cluster|node]_txn_execution_insightsvirtual tables.